-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error logging #4351
Improve error logging #4351
Conversation
|
||
import { getQueryParams, isTopNavbar } from './GrafanaPluginRootPage.helpers'; | ||
|
||
import grafanaGlobalStyle from '!raw-loader!assets/style/grafanaGlobalStyles.css'; | ||
|
||
export const GrafanaPluginRootPage = (props: AppRootProps) => { | ||
useOnMount(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any difference between this and a useEffect
with []
params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this super simple hook is just to avoid putting [] as dependency array every time you want effect to run only on mount. And it has explicit naming
…ll into brojd/improve-error-logging
What this PR does
Checklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.