Make type required when creating an escalation policy step #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasb
added
pr:no public docs
matiasb
force-pushed
the
matiasb/escalation-policy-required-step
branch
from
d0d2898
to
3233748
Compare
mderynck
reviewed
May 16, 2024
| @@ -303,8 +303,11 @@ def test_should_be_considered_for_rbac_permissioning( | |||
| NUM_ORGS = 5 | |||
| settings.CLOUD_RBAC_ROLLOUT_PERCENTAGE = rollout_percentage | |||
|
|
|||
| # make sure there are no other orgs around | |||
| Organization.objects.all().delete() | |||
There was a problem hiding this comment.
Can we do this in a different way? Scary if someone runs this test connected to the wrong environment.
There was a problem hiding this comment.
After checking with Joey, it seems we can delete this test (RBAC rollout is already in progress and this will be cleanup soon anyways).
FWIW, we shouldn't run tests affecting any real db in any case, right? (they would break lots of things independently of this particular bit :-))
matiasb
force-pushed
the
matiasb/escalation-policy-required-step
branch
from
3233748
to
6093a3f
Compare
iskhakov
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/grafana/oncall-private/issues/2689