Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Revises and reorganizes content for installing additional dependencies per the GX 1.0 ToC #9934

Merged

Conversation

Rachel-Reverie
Copy link
Contributor

Description

  • Adds "Install additional dependencies" topic per the revised 1.0 ToC
  • Revises content provided for clarity.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented May 15, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit e829afe
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6647814e1a2f70000802cc45
😎 Deploy Preview https://deploy-preview-9934.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.07%. Comparing base (4a6c924) to head (e829afe).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9934   +/-   ##
========================================
  Coverage    79.07%   79.07%           
========================================
  Files          454      454           
  Lines        38475    38475           
========================================
  Hits         30425    30425           
  Misses        8050     8050           
Flag Coverage Δ
3.10 65.30% <ø> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 65.30% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.10% <ø> (ø)
3.11 aws_deps 45.25% <ø> (ø)
3.11 big 54.22% <ø> (ø)
3.11 databricks 46.37% <ø> (ø)
3.11 filesystem 60.05% <ø> (ø)
3.11 mssql 49.44% <ø> (ø)
3.11 mysql 49.51% <ø> (ø)
3.11 postgresql 53.74% <ø> (ø)
3.11 snowflake 47.06% <ø> (ø)
3.11 spark 57.05% <ø> (ø)
3.11 trino 51.60% <ø> (ø)
3.8 65.32% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.11% <ø> (ø)
3.8 aws_deps 45.27% <ø> (ø)
3.8 big 54.24% <ø> (ø)
3.8 databricks 46.39% <ø> (ø)
3.8 filesystem 60.06% <ø> (ø)
3.8 mssql 49.42% <ø> (ø)
3.8 mysql 49.49% <ø> (ø)
3.8 postgresql 53.73% <ø> (ø)
3.8 snowflake 47.08% <ø> (+<0.01%) ⬆️
3.8 spark 57.02% <ø> (ø)
3.8 trino 51.59% <ø> (ø)
3.9 65.32% <ø> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 48.22% <ø> (ø)
docs-creds-needed 49.38% <ø> (ø)
docs-spark 48.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kwcanuck kwcanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick review. Feel free to implement or ignore the edits.

@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue May 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 17, 2024
…ndencies per the GX 1.0 ToC (#9934)

Co-authored-by: Rob Gray <104205257+kwcanuck@users.noreply.github.com>
@Rachel-Reverie Rachel-Reverie removed this pull request from the merge queue due to a manual request May 17, 2024
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue May 20, 2024
Merged via the queue into develop with commit 02ff711 May 20, 2024
64 checks passed
@Rachel-Reverie Rachel-Reverie deleted the d/doc-734/gx_1-0_install_additional_dependencies branch May 20, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants