Created and updated times #56

mlshapiro · 2023-12-23T18:54:23Z

Add created/updated timestamps to block delimiter (#30)

New delimiter format with -c for created time and -u for updated time with ISO strings following (YYYY-MM-DDTHH:mm:ssZ)

\n∞∞∞(${languageTokensMatcher})(-a)?(-c${timeMatcher})?(-u${timeMatcher})?\n

Presents the updated time in the status bar:

heyman · 2023-12-23T23:45:28Z

If this is headed in the right direct, i can keep going

I think so 👍! It was a while since I messed with the Lezer stuff, and the Lezer code in Heynote is the full extent of my experience with it, so I'm certainly not an expert when it comes to the grammar syntax.

heyman · 2023-12-24T00:14:49Z

A thought that popped up in my mind when thinking about this.. I think it would be a good idea to investigate how we could implement the actual updating of the timestamps in the Codemirror text buffer. I'm guessing that this should be done with some kind of transactionFilter, but the text in the reference manual seems to indicate that it might not be a very good idea. So it's probably smart to investigate that to make sure it's not a showstopper due to performance issues or similar.

heyman · 2023-12-25T01:57:21Z

We would only need a transactionFilter to update the update times with every change. So it even if it turns out that it's a showstopper, it shouldn't prevent us from adding creation time.

mlshapiro · 2023-12-28T05:39:18Z

src/components/App.vue

@@ -131,6 +135,8 @@
            :theme="theme"
            :systemTheme="systemTheme"
            :allowBetaVersions="settings.allowBetaVersions"
+            :createdTime="createdTime"


This doesn't currently show the createdTime, so these props could be removed.

If you want to show the createdTime somewhere, then the prop could be kept

mlshapiro · 2023-12-28T05:40:05Z

src/components/StatusBar.vue

+        <div class="status-block line-number" v-if="updatedTime !== ''">
+            Updated <span class="num">{{ updatedTime }}</span>
+            <!-- Show the created time as well -- too verbose -->
+            <!-- <span v-if="createdTime !== updatedTime">&nbsp;&nbsp;(Created {{ createdTime }})</span> -->


This looked too busy to me. Perhaps the better UI would be to click on the udpated time to see the created time? That wouldn't be clear either though.

Feel free to adjust this as you see it

mlshapiro · 2023-12-28T05:40:37Z

src/editor/block/block.js


+const languageTokensMatcher = LANGUAGES.map(l => l.token).join("|")


I had to copy this snippet over a few times - perhaps this goes in languges.js and can be imported?

mlshapiro · 2023-12-28T05:41:48Z

src/editor/block/commands.js

    if (state.doc.sliceString(block.delimiter.from, block.delimiter.to).match(delimRegex)) {
-        //console.log("changing language to", language)
+        const createdTimeStr = block.time.created || ""
+        const updatedTimeStr = block.time.updated ? newUpdatedTime() : ""


This isn't explicitly needed - this will get updated by the transactionFilter, but it doesn't hurt to add it since the other function has the transactionFilter has the debounce

mlshapiro · 2023-12-28T05:42:27Z

src/editor/lang-heynote/external-tokens.js

@@ -23,7 +24,7 @@ export const noteContent = new ExternalTokenizer((input) => {
        // so we don't need to check for the rest of the token
        if (current === FIRST_TOKEN_CHAR && next === SECOND_TOKEN_CHAR) {
            let potentialLang = "";
-            for (let i=0; i<18; i++) {
+            for (let i=0; i<62; i++) {


Note I added the 40 characters of the times to this.

… delimiter

Note I updated the `delimRegex` here to use the similar pattern elsewhere

mlshapiro · 2024-01-02T21:41:31Z

@heyman this is "ready to go" but I'm having trouble solving two (known) bugs:

When I "Select All" (twice) to get the whole scratch pad, and then "delete", I'm left with 2 blocks, not one. I can't fingure out why the defaultSelectAll doesn't actually select all the buffer text.
I can't get certain language-detection.spec.js tests to pass. When I debug the tests, the .pressSequentially(... command types in the text and then ends up in an infinite loop of creating new blocks. I can't figure out where this is coming from and whether the bug is in the test or application side.

Any insight on either?

mlshapiro changed the title ~~[DRAFT] Created and updated times (#30)~~ [DRAFT] Created and updated times Dec 23, 2023

mlshapiro marked this pull request as draft December 25, 2023 03:22

mlshapiro force-pushed the main branch 2 times, most recently from a70a0bd to 9e68f54 Compare December 28, 2023 05:36

mlshapiro changed the title ~~[DRAFT] Created and updated times~~ Created and updated times Dec 28, 2023

mlshapiro marked this pull request as ready for review December 28, 2023 05:37

mlshapiro commented Dec 28, 2023

View reviewed changes

mlshapiro force-pushed the main branch from 1373e9e to 07025ec Compare December 30, 2023 18:35

mlshapiro added 13 commits January 2, 2024 16:38

Draft a syntax for created and updated times

02ebd20

Add time module with helper methods for creating and parsing times in…

9960680

… delimiter

Add created time to status bar

4b23af2

Add updated time to status bar

a348d6e

Present the year if its previous to current year

e842a10

Store full time strings on block state (with delimiter)

fc5afe7

Only show created time if its different than the updated time

d2e31e8

Only show updated time

8918c30

Update updatedTime when language is changed.

399a189

Note I updated the `delimRegex` here to use the similar pattern elsewhere

Update updated time on each transaction that changes the document.

a5c8d53

Fix case when deleting across blocks

1497cfe

Give updated time its own css to avoid confusion

44e764b

Add created/updated times to initial content

761ca5e

mlshapiro force-pushed the main branch from 07025ec to 761ca5e Compare January 2, 2024 21:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created and updated times #56

Created and updated times #56

mlshapiro commented Dec 23, 2023 •

edited

heyman commented Dec 23, 2023

heyman commented Dec 24, 2023

heyman commented Dec 25, 2023

mlshapiro Dec 28, 2023

mlshapiro Dec 28, 2023

mlshapiro Dec 28, 2023

mlshapiro Dec 28, 2023

mlshapiro Dec 28, 2023

mlshapiro commented Jan 2, 2024 •

edited


		const languageTokensMatcher = LANGUAGES.map(l => l.token).join("\|")

Created and updated times #56

Are you sure you want to change the base?

Created and updated times #56

Conversation

mlshapiro commented Dec 23, 2023 • edited

heyman commented Dec 23, 2023

heyman commented Dec 24, 2023

heyman commented Dec 25, 2023

mlshapiro Dec 28, 2023

Choose a reason for hiding this comment

mlshapiro Dec 28, 2023

Choose a reason for hiding this comment

mlshapiro Dec 28, 2023

Choose a reason for hiding this comment

mlshapiro Dec 28, 2023

Choose a reason for hiding this comment

mlshapiro Dec 28, 2023

Choose a reason for hiding this comment

mlshapiro commented Jan 2, 2024 • edited

mlshapiro commented Dec 23, 2023 •

edited

mlshapiro commented Jan 2, 2024 •

edited