Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updates #54

wants to merge 3 commits into from

Conversation

aouerf
Copy link

@aouerf aouerf commented Sep 21, 2018

This also fixes commands not being displayed because redirection wasn't working properly with the old URL.

aouerfelli added 3 commits September 21, 2018 14:48
 - updated Gradle wrapper
 - updated Android Gradle plugin and SDK config
 - updated Kotlin
@clove3am
Copy link

clove3am commented Dec 19, 2018

@aouerfelli thanks for creating a pull request. It looks like @hidroh is no longer maintaining tldroid. I was wondering if you could create a release with your fork of the project. Unfortunately I lack the expertise with compiling Android apks. It would be great to have a working release.

@aouerf
Copy link
Author

aouerf commented Dec 23, 2018

@caltlgin I might get around to it one day but if you want to build it for yourself, all you have to do is clone my fork on the aouerf/updates branch (git clone -b aouerf/updates https://github.com/aouerfelli/tldroid.git), open it in Android Studio, then select Build -> Build Bundle(s) / APK(s) -> Build APK(s).

@aouerf aouerf mentioned this pull request Dec 23, 2018
@hidroh
Copy link
Owner

hidroh commented Dec 24, 2018

@aouerfelli could you point out the main changes in your PR since it includes other upgrades which I understand is necessary for the code to compile but makes it difficult to review? Once reviewed I can manually ported it over. Thanks very much and sorry for taking long time to respond!

@aouerf
Copy link
Author

aouerf commented Dec 24, 2018

@hidroh No problem! This commit is the one you're looking for.

@zsnmwy
Copy link

zsnmwy commented Feb 8, 2019

tldroid (need unzip).zip

I use this commit to build it.

It's works on my phone.

screenshot_2019-02-08-14-45-36-048_io github hidr

screenshot_2019-02-08-14-45-43-772_io github hidr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants