Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts error #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix scripts error #113

wants to merge 3 commits into from

Conversation

Sianglife
Copy link

1.Fixed download.sh cannot download zip data by using wget.

@alexVinarskis
Copy link

Can confirm that fix to download script works (unlike og one), thanks!

Regarding "remove unused utilities", perhaps worth adding to README, that since local iasl is removed, it needs to be install on host system, brew install --cask maciasl for mac, or sudo apt-get install iasl for linux

@xick
Copy link
Contributor

xick commented Sep 27, 2023

Thanks can confirm it's working, however needs to pointed out wget it's not installed nor in windows or mac os.
Btw sometimes scripts fails to download all zips, claiming 'missing url' but in fact I think it's a denied request from github for too many requests. We could include an option to put an api key, or add a wait between downloads could be acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants