TST / Workflows: Get slack notifications for docker image build #30891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
commented
May 18, 2024
| if: always() | ||
| uses: huggingface/hf-workflows/.github/actions/post-slack@main | ||
| with: | ||
| slack_channel: "C073ZTN10A1" |
There was a problem hiding this comment.
Change to correct env name in the future and use a secret
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
May 18, 2024
younesbelkada
commented
May 20, 2024
younesbelkada
commented
May 21, 2024
ydshieh
approved these changes
May 21, 2024
|
Thanks so much for the review @ydshieh ! |
Vaibhavs10
pushed a commit
to Vaibhavs10/transformers
that referenced
this pull request
May 22, 2024
…ingface#30891) * Get slack notifications for docker image build * Apply suggestions from code review * Apply suggestions from code review
itazap
pushed a commit
that referenced
this pull request
May 22, 2024
* Get slack notifications for docker image build * Apply suggestions from code review * Apply suggestions from code review
itazap
pushed a commit
that referenced
this pull request
May 24, 2024
* Get slack notifications for docker image build * Apply suggestions from code review * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, as similarly as huggingface/peft#1723 - I created a new slack channel to receive notifications on the docker image build status for all our docker images
We do that in PEFT / diffusers (huggingface/diffusers#7938)
Related to: #30890
cc @ydshieh