Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy multiple custom files to /boot #180

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jsiebens
Copy link

@jsiebens jsiebens commented Jul 9, 2020

I'm using this flash utility to write raspian and ubuntu images but I would like to copy multiple custom files to /boot.
This pull request adds the ability to do this with multiple -F/--file flags like: flash --file usercfg.txt --file network-config ...

Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That looks good so far.
Could you update the usage and the README.md that it‘s possible to use —file multiple times?
At least the README should show an example for multiple files as you showed in the PR description.
Adding a test would be super cool, if you have time.

Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
@jsiebens
Copy link
Author

Hi, thanks for the feedback. I've added some additional info on how to copy multiple files and also added a test case.

Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants