Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update meson, cmake setup #6151

Merged
merged 1 commit into from
May 21, 2024
Merged

build: update meson, cmake setup #6151

merged 1 commit into from
May 21, 2024

Conversation

rtgiskard
Copy link
Contributor

  • meson
    . Fix run_command() check warning
    . Drop lines for compatibility, as it's already using c++23

  • cmake
    . Generate compile_commands.json by default, coder-friendly
    . Position independent build for __FILE__

Describe your PR, what does it fix/add?

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Is it ready for merging, or does it need work?

ready

- meson
. fix run_command() check warning
. drop lines for compatability, as it's already using c++23

- cmake
. generate `compile_commands.json` by default
. position independent build: __FILE__
@vaxerski vaxerski requested a review from fufexan May 19, 2024 20:33
@rtgiskard
Copy link
Contributor Author

rtgiskard commented May 20, 2024

And @fufexan, I'm trying to code with lsp/clangd v18.1.3 from nvim/mason for this project, if the compile_commands.json is generated with meson, clangd will complain a lot, while with current CMake setup, it works fine, though both of them build it well. Are you setting up this project with meson?

@fufexan
Copy link
Member

fufexan commented May 21, 2024

@rtgiskard I'm not using Meson at the moment, and it's going to be removed sometime in the future. If you have an idea how we can fix the generation of compile_commands.json, open another PR or let's discuss it on Discord/Matrix.

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fufexan fufexan merged commit 3c907f7 into hyprwm:main May 21, 2024
10 checks passed
@rtgiskard rtgiskard deleted the dev.build branch May 22, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants