#6098: Add Config Flag to hyprctl systeminfo
#6160
Merged
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
May 20, 2024
if sliding and resizing, include the slide in the resize to avoid off-screen surfaces. fixes hyprwm#6150
- meson . fix run_command() check warning . drop lines for compatability, as it's already using c++23 - cmake . generate `compile_commands.json` by default . position independent build: __FILE__
…prwm#6182) * add monitor fallback option * format
When `region_size` is set in the config (non-empty `boundBox`), cursor is mapped to wrong coordinate because `CBox::translate` mutates `TAB->boundBox`, making all subsequent coordinate calculations wrong. This also fixes the edge case where user sets `region_position` but not `region_size`.
Added a simple way to get basic info about the GPU on ARM based systems
on exit of hyprland the CMonitor destroy signal comes after the compositor has been destructed, causing a heap use after free. add if check to ensure compositor exist and isnt shutting down when its triggered.
vaxerski
reviewed
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6098
Describe your PR, what does it fix/add?
Frequently I will look through issues on Github and be unable to repro the issue because there is no config attached to the issue. My hope is that by adding a --config/-c flag to systeminfo and asking for config files will significantly improve this problem and hopefully save developer time from time wasted trying to repro unclear issues.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Should be fine. Let me know if I should correct wording in the template.
Is it ready for merging, or does it need work?
Should be ready.