-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] configure resources dir using PLUG_RESOURCES_DIR variable #926
base: cmake
Are you sure you want to change the base?
Conversation
thanks for the PR. It's good if you can make a PR for each thing in future. I don't understand 2. On my mac I just get an empty folder "out" in the build directory |
Yep, sure – next time every piece of functionality will be in its own PR. I've included 'plugin_build_dir' commit just because I thought it was unintentionally skipped :) Regarding |
I'm not totally happy with the structure & MSVC projects that the cmake build scripts are making at the moment so I will improve this and maybe edit the script if needed |
Let's discuss it! I'm ready to help with improvements. |
2606238
to
9a7e553
Compare
2 changes in this PR:
1. Ability to configure resources dir using PLUG_RESOURCES_DIR variable
This can be handy when a project has a layout like this:
PLUG_RESOURCES_DIR
inCMakeLists.txt
can be set to:If a user doesn't specify
PLUG_RESOURCES_DIR
, it'll be initialized to${CMAKE_SOURCE_DIR}/resources
.2. create 'plugin_build_dir' at build system generation time
It seems that this change has been lost in the process of transferring changes from #923