feat(server): healthchecks for PG and redis #9590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In #9583 I am requesting that we make the healthchecks active by default using the HEALTHCHECK command in the dockerfiles, so we shouldn't need the documentation around the docker compose changes. If that change makes it in the docs will need to be updated to reflect that |
aviv926
reviewed
May 21, 2024
mmomjian
commented
May 21, 2024
| command: ["postgres", "-c" ,"shared_preload_libraries=vectors.so", "-c", 'search_path="$$user", public, vectors', "-c", "logging_collector=on", "-c", "max_wal_size=2GB", "-c", "shared_buffers=512MB", "-c", "wal_compression=on"] | ||
| restart: always |
There was a problem hiding this comment.
Is there any reason the database was the only core service not restart: always in prod?
Same question for grafana and prometheus, though I did not make a change there.
mmomjian
added
deployment
mmomjian
changed the title
bo0tzz
approved these changes
May 22, 2024
Yea, this is the only way without pushing our own containers |
zackpollard
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #9583 in non-Immich services
this is a non breaking change. Users who add this will get the benefit of the healthcheck, if they have checksums enabled (new installs starting with 1.104.0)
Users with older setups will have a
unhealthystatus. This can be fixed by removing everything after the firstexit 1in the database health check test: line