Port Gitlab MR !1887 to 2.2.x #125
Conversation
New parameters have been added for MySQL connection.
The read- and write- timeouts are only allowed for the MySQL backend. The tcp-user-timeout is only allowed for the postgresql backend.
It says that the timeouts are only effective for TCP connections.
|
We encourage any potential contributors to request their accounts at gitlab.isc.org get an upgrade if they want to contribute. You should be able to open an issue in our Kea project in Gitlab just by making an account and doing something useful (like opening an issue) within a day of opening the account. Anytime you want to submit a Merge Request to our primary repo at gitlab.isc.org, ask us (like in the issue) to give you a project allocation and then you can create your own fork and work on it. This takes us like, 2 seconds. We don't allow these for random people on the Internet because we get absolutely truck loads of spam users creating accounts on our gitlab so they can post their backlinks or porn or whatever. Alternatively, you can attach a patch to your issue (although I think we prefer the MR approach). This is no comment on your efforts to backport the fix, I am just posting this comment here for others in your situation. We welcome participation at https://gitlab.isc.org/isc-projects/kea . Regards - Vicky |
|
Thanks for the information. I opened https://gitlab.isc.org/isc-projects/kea/-/issues/2735 for further discussion. |
This ports the Gitlab Merge Request 1887 that solves Gitlab Bug 2688 to Kea 2.2.x. This is a purely mechanical port; it only rebases the commits on top of branch
v2_2and fixes merge conflicts.We encountered the same bug as the original reporter; with this patch in place the bug went away. I couldn't submit the PR/MR on ISC's Gitlab instance, so I hope it is OK to post it here.