fix altstatname for subset clusters #51136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
the
size/M
|
/test integ-security-multicluster |
hzxuzhonghu
reviewed
May 20, 2024
| @@ -186,6 +186,11 @@ func (cb *ClusterBuilder) buildSubsetCluster( | |||
| return nil | |||
| } | |||
|
|
|||
| if len(cb.req.Push.Mesh.OutboundClusterStatName) != 0 { | |||
| subsetCluster.cluster.AltStatName = telemetry.BuildStatPrefix(cb.req.Push.Mesh.OutboundClusterStatName, | |||
There was a problem hiding this comment.
why set again as it has been set in buildCluster
There was a problem hiding this comment.
We do not have subset name there so SUBSET_NAME wont be replaced
There was a problem hiding this comment.
We can get the subset from the clustername.
This way, we do some duplicate work on other fields
There was a problem hiding this comment.
You have to parse it for every cluster and get subset name - currently this repetition only happens for subset clusters . IMO this is much faster because subset clusters would be few in number. Unless we change the current signature and pass subset name - we can't avoid this.
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
hzxuzhonghu
approved these changes
May 20, 2024
ramaraochavali
added
the
cherrypick/release-1.22
|
In response to a cherrypick label: new pull request created: #51209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression caused in #46352 . The code has been removed