Fix CI for macos-latest #5142
Fix CI for macos-latest #5142
Conversation
| @@ -370,7 +373,11 @@ ecma_number_remainder (ecma_number_t left_num, /**< left operand */ | |||
|
|
|||
| if (ecma_number_is_zero (r) && ecma_number_is_negative (left_num)) | |||
| { | |||
| #ifdef __APPLE__ | |||
| r = ecma_number_negate (r); | |||
| #else /* !__APPLE__ */ | |||
There was a problem hiding this comment.
Is this the right macro guard to use? If this is a compiler bug then is it OK to use a guard on the platform? Which versions of which compiler are affected? Is there an issue report for this anywhere that could be linked for reference? Is there no cli option for the compiler to ensure that signed/negative zeros are properly handled, to work around the issue without code base change?
There was a problem hiding this comment.
This bug only occurs on macos-14, which by default uses Clang, Version: 15.0.0.15000040
this seems to be describing the same problem: llvm/llvm-project#82744 (for the first issue, I was unable to find a report for the second)
These issues first popped up when macos-latest in github actions switched from macos-13 to macos-14.
The easiest fix for now without a codebase change would be to go back to using macos-13 for the time being, and switch back to macos-latest at a leter date when these issues have hopefully been resolved.
Due to compiler bugs present in the latest version of clang on macos: Roll back macos version used by github actions from `macos-latest` (`macos-14`) to `macos-13`: Some modulo operations were failing, such as `-1 % -1` when compiler optimizations were enabled Disable `-Wliteral-range` for test-math.c on macos, because it was falsely raised for `isnan`, `isinf`, and `isfinite ` macros. JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
Add a non-inlineable function for negating a number on macos, bacause due to a compiler bug
r = -rwas being optimized out, resulting in some modulo operations failing such as-1 % -1or-1 % 1.Disable
-Wliteral-rangefortest-math.con macos, because it was falsely raised forisnan,isinf, andisfinitemacros.