Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & automatically build Docker image #340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

minus7
Copy link

@minus7 minus7 commented May 27, 2023

  • Refactor Dockerfile
    • Use code from context instead of cloning the repo
    • Download dependencies first for caching
    • Run as unprivileged account (note that this break running on ports
      <1024 on Docker <20.03; default ports changed accordingly)
  • I'm not actually sure the ca-certificates package is required in the image, requesting certificates seems to work without it, though I did not test fully obtaining one.
  • Automatically build and deploy Docker image via GitHub Actions
    • I mainly did this so I can use it right away. Dunno if it makes sense, especially since images are on Docker Hub already.

- Use code from context instead of cloning the repo
- Download dependencies first for caching
- Run as unprivileged account (note that this break running on ports
  <1024 on Docker <20.03; default ports changed accordingly)
@gbonnefille
Copy link

As stated in #293 it is possible to reduce the footprint and increase security, going from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants