-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated sqlite3 and better-sqlite3 to use more accurate numeric types #6063
base: master
Are you sure you want to change the base?
Updated sqlite3 and better-sqlite3 to use more accurate numeric types #6063
Conversation
Check this for more context on what the PR does #5789 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be breaking change even though it's correct, @kibertoad WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add another tests in integration so we are sure this is working...
@@ -755,6 +755,7 @@ describe('BetterSQLite3 SchemaBuilder', function () { | |||
equal(tableSql[0].sql, 'alter table `users` add column `foo` float'); | |||
}); | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
There are two folders |
Fixing
sqlite3
andbetter-sqlite3
numeric types. When trying to useknex.decimal()
orknex.double()
with sqlite3 it turns them tofloat
. Issue #5789