-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate images coming with <none>:<none> tag #11209
base: master
Are you sure you want to change the base?
fix: duplicate images coming with <none>:<none> tag #11209
Conversation
Welcome @aryasoni98! |
Hi @aryasoni98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aryasoni98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's not clear at all this is an actual problem rather than some artifacts of the display by nerdctl (and others).
Moreover, you should not add tasks directly to cluster.yml
|
Thank you for the feedback. It's understood that the issue might stem from artifacts of the display by tools like nerdctl and others. The intention behind the changes was to ensure clarity and consistency across different environments, but I appreciate the clarification that tasks should not be added directly to cluster.yml. Instead, I will refactor the changes to ensure modularity and maintain the intended structure without directly modifying cluster.yml. Your guidance is valuable for maintaining best practices in the project. Thank you for the direction. |
What type of PR is this?
What this PR does / why we need it:
This PR resolves the issue of duplicate Docker images showing up with
<none>:<none>
tags when using containerd and nerdctl. The solution involves adding a task to remove these duplicate images after containerd setup.Which issue(s) this PR fixes:
Fixes #11101
Special notes for your reviewer:
Does this PR introduce a user-facing change?: