Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate images coming with <none>:<none> tag #11209

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aryasoni98
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR resolves the issue of duplicate Docker images showing up with <none>:<none> tags when using containerd and nerdctl. The solution involves adding a task to remove these duplicate images after containerd setup.

Which issue(s) this PR fixes:
Fixes #11101

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixed issue of duplicate Docker images with <none>:<none> tags by removing dangling images post containerd setup.

Copy link

linux-foundation-easycla bot commented May 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 19, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @aryasoni98!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @aryasoni98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aryasoni98
Once this PR has been reviewed and has the lgtm label, please assign liupeng0518 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 19, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2024
@aryasoni98 aryasoni98 changed the title aryasoni98/duplicate images none fix: duplicate images coming with <none>:<none> tag May 19, 2024
@VannTen
Copy link
Contributor

VannTen commented May 19, 2024 via email

@aryasoni98
Copy link
Author

It's not clear at all this is an actual problem rather than some artifacts of the display by nerdctl (and others). Moreover, you should not add tasks directly to cluster.yml

Thank you for the feedback.

It's understood that the issue might stem from artifacts of the display by tools like nerdctl and others. The intention behind the changes was to ensure clarity and consistency across different environments, but I appreciate the clarification that tasks should not be added directly to cluster.yml. Instead, I will refactor the changes to ensure modularity and maintain the intended structure without directly modifying cluster.yml.

Your guidance is valuable for maintaining best practices in the project. Thank you for the direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate images coming with <none>:<none> tag
3 participants