Check that PRs have correctly ran the sidebar gen #11212
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
The script should be self-sufficient (with no need to manually specify a redirection). This makes it easier to run it as part of pre-commit and CI.
VannTen
force-pushed
the
cleanup/check_sidebar_ci
branch
from
7f0de55
to
76dae63
Compare
k8s-ci-robot
added
size/S
If we don't, find output can change depending on system locale, which will produce inconsistent results.
|
Thank you @VannTen 😊 |
|
/label tide/merge-method-merge
|
k8s-ci-robot
added
the
tide/merge-method-merge
|
Thanks @VannTen /approve |
k8s-ci-robot
added
the
approved
|
/cc @MrFreezeex
|
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, VannTen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Follow-up to #11128 run the script in CI to check there is nothing to change
Does this PR introduce a user-facing change?:
@Payback159