Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-sitter: Add the .slint UI language #3025

Closed
wants to merge 2 commits into from

Conversation

flukejones
Copy link

  • Added an entry to CHANGELOG.md if this change could be valuable to users

This is paired with lapce/tree-sitter-grammars#28

I don't know if this is the correct method to go about this. There does not appear o be much documentation about adding languages.

Slint is a UI made with rust https://slint.dev/

@panekj
Copy link
Collaborator

panekj commented Feb 27, 2024

We don't accept more grammars built-in to lapce

@flukejones flukejones force-pushed the master branch 2 times, most recently from 22e4367 to 41557ce Compare March 5, 2024 03:30
@panekj
Copy link
Collaborator

panekj commented Jun 1, 2024

The grammar is not open source so it can't be added

@panekj panekj closed this Jun 1, 2024
@aurindam
Copy link

aurindam commented Jun 2, 2024

@panekj Its licensed under GPLv3.

@panekj
Copy link
Collaborator

panekj commented Jun 2, 2024

@aurindam it is absolutely not, there is a directory with 3 different licences without any guidance what is supposed to be used (probably same how slint is licenced but I'm not going to be guessing)

Cargo.toml, pyproject.toml and etc. specify MIT, which means that no one bothered to actually licence that repository properly

@aurindam
Copy link

aurindam commented Jun 2, 2024

@panekj Would a README in that folder clarifying that its triple licensed (like Slint) be sufficient?

@panekj
Copy link
Collaborator

panekj commented Jun 2, 2024

@aurindam yes, if it also includes a note on how the parser code is licenced, if grammar.js is to be triple-licenced like slint according to the SPDX in file with parser code as MIT or the generated bindings/parser code should also be triple-licenced together with grammar.js

@hunger
Copy link

hunger commented Jun 3, 2024

@panekj: I just pushed a PR re-licensing the gammar.js to MIT (in the mono repo) and will put a copy of MIT into LICENSE.md in that tree-sitter-slint repo once that gets visible there. I hope that makes everything clearer.

Thanks for raising this, licensing is always tricky to get right and feedback like this is really helpful.

@hunger
Copy link

hunger commented Jun 3, 2024

@panekj: I updated slint-ui/tree-sitter-slint. It's README.md states that we only hold copyright to grammar.js, which contains MIT now in its SPDX identifier. LICENSES contains MIT.txt only now and the README points to that file. I hope this makes it crystal clear that our tree-sitter parser is open source software.

@panekj
Copy link
Collaborator

panekj commented Jun 3, 2024

@hunger Thank you, it definitely works for me and assures the status of grammar "legality" :)

@hunger
Copy link

hunger commented Jun 4, 2024

Great! Anything else I can do to help from our side?

@panekj
Copy link
Collaborator

panekj commented Jun 4, 2024

Nope (unless you're interested in preparing queries for Lapce), I'm in progress of restructuring (and adding much more) grammars here: https://github.com/lapce/tree-sitter-grammars/tree/be-less-stupid
Languages/queries are updated here: #3279 (partially, will be cherry-picked to master once ready) but we're planning on moving queries to the repo with grammars

Overall its just time consuming (and tedious) to prepare logic for updating and distributing grammars.

@flukejones
Copy link
Author

@panekj will you be managing this from now, or shall I update and reopen the PR?

@panekj
Copy link
Collaborator

panekj commented Jun 5, 2024

@panekj will you be managing this from now, or shall I update and reopen the PR?

If you remove the tree-sitter grammar (just add the Syntax definition and slint LSP id in proxy buffer) I'll merge it

@flukejones
Copy link
Author

@panekj should be good to reopen and merge now I think

@hunger
Copy link

hunger commented Jun 7, 2024

@panekj: Sorry, I am not into GUI IDEs anymore. Been there, done that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants