Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing node version and resolving errors of "Position::TrayFixedCenter not found problem" #757

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dogedefi
Copy link

@dogedefi dogedefi commented Apr 2, 2023

No description provided.

@dogedefi dogedefi changed the title chore: fixed a avaliable node version with nvm Fixed node version and fix Position::TrayFixedCenter not found problem Apr 2, 2023
@txie-sending
Copy link

I have observed that this pull request holds significant importance. Its absence could lead to errors for developers during local development. Would you kindly review this pull request and provide any feedback or merge it at your earliest convenience?

Thank you for your valuable time and consideration.

@luisnquin
Copy link

Hey maintainers, please merge this inmediately

olljanat added a commit to olljanat/ChatGPT that referenced this pull request Apr 16, 2023
olljanat added a commit to olljanat/ChatGPT that referenced this pull request Apr 16, 2023
olljanat added a commit to olljanat/ChatGPT that referenced this pull request Apr 16, 2023
@dogedefi dogedefi changed the title Fixed node version and fix Position::TrayFixedCenter not found problem Fixing node version and resolving errors of "Position::TrayFixedCenter not found problem" May 6, 2023
@nhuhoang0701
Copy link

@lencx Can you have a look and merge this PR? The compilation fails because of this error.

@gyrusdentatus
Copy link

Great job with this PR, thanks for saving me at least 10 min of my life chasing the bug.
@web3monkey @nhuhoang0701 @txie-sending

I wonder why @lencx does not want to merge it or is avoiding it for some reason ...?

Especially if you put in the README.md that there was some trojanized version, I want to compile things on my own and not rely on potentially very dangerous binaries(we are talking Rust here so you can do pretty much anything you want ...)

@lencx
Copy link
Owner

lencx commented May 25, 2023

This issue is caused by Cargo.lock, not from the code files. I have released the latest version v1.0.0.

@gyrusdentatus
Copy link

This issue is caused by Cargo.lock, not from the code files. I have released the latest version v1.0.0.

Hmm, if that is the case - I would open a PR that fixes this issue with a simple shell script.

I also had to create dist/ directory in the root of the git repo otherwise it fails to compile.

  • using the latest Cargo, because I thought that it could be due to my Cargo being out-dated at first.

What is your opinion, people?

There are other cleaner ways though to do this. This issue could have been solved months ago if you replied a little bit earlier. I get it that you don't really care and have time to take care of this for other devs, but this is trivial ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants