usb_control: Use usbd_request_return_codes enum better #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there are only the three values possible, this change is only a boolean transformation and changes nothing in the execution. It makes the code easier to read as it reflects the intention of the code better. For the curious it also makes it easier to look up where the USBD_REQ_NEXT_CALLBACK value comes to use. Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
When reading the code isolated it is not obvious which enum values will correspond to true or false so add proper comparisons instead. Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the second commit I am not sure how to make the whitespace best within 80 chars width, amend to your desire.