windows: when usb debug is on in android, libusb cannot open the android device #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid device Signed-off-by: dayo7116 <lidayongg@gmail.com>
|
Please provide a description of what this change does in general, not only the problem that you are seeing. Also explain what this has to do with "usb debug is on in android device". |
tormodvolden
reviewed
Dec 8, 2023
| @@ -2708,9 +2708,11 @@ static int winusbx_open(int sub_api, struct libusb_device_handle *dev_handle) | |||
| default: | |||
| return LIBUSB_ERROR_IO; | |||
| } | |||
| } else if (INVALID_HANDLE_VALUE == file_handle){ | |||
There was a problem hiding this comment.
It is a bit confusing that you use Yoda syntax here, while using normal syntax in line 2701.
|
I believe the former logic was:
After the update:
The new implementation is a bit confusing to me. I'd replace Since the new logic no longer guarantees that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the usb debug is on in android device, libusb fails to open the android device on windows.
This PR fixes the problem. Please Review