WIP: add clang thread safety annotations #1419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youw
reviewed
Jan 1, 2024
libusb/libusbi.h
Outdated
| @@ -44,6 +44,17 @@ | |||
| #define static_assert(cond, msg) _Static_assert(cond, msg) | |||
| #endif | |||
|
|
|||
| /* https://clang.llvm.org/docs/ThreadSafetyAnalysis.html */ | |||
| #ifdef __clang | |||
There was a problem hiding this comment.
I believe this is how it is suggested by ThreadSafetyAnalysis.html
Suggested change
| #ifdef __clang | |
| #if defined(__clang__) && (!defined(SWIG)) |
Youw
reviewed
Jan 1, 2024
Yes. I haven't even tried that yet, because also required is that the threading functions be annotated too. pthread.h on my OS is not. It might be possible to annotate the wrappers in threads_posix.h though, which I will try...
Correct. The annotations also require that the mutex is declared before variables it protects, which is why I moved some things around. |
|
@mcuee not sure the macOS tag is appropriate, there's nothing macOS specific here. |
seanm
force-pushed
the
clang-thread-safety
branch
2 times, most recently
from
a1ef646
to
a9fee51
Compare
seanm
force-pushed
the
clang-thread-safety
branch
from
a9fee51
to
0a47f0c
Compare
This was referenced Jan 5, 2024
seanm
force-pushed
the
clang-thread-safety
branch
from
0a47f0c
to
02d6423
Compare
seanm
force-pushed
the
clang-thread-safety
branch
from
02d6423
to
0aabba9
Compare
seanm
force-pushed
the
clang-thread-safety
branch
from
0aabba9
to
d0874d9
Compare
seanm
force-pushed
the
clang-thread-safety
branch
from
d0874d9
to
2095e55
Compare
… (for C++ compat)
seanm
force-pushed
the
clang-thread-safety
branch
from
2095e55
to
94bf9ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://clang.llvm.org/docs/ThreadSafetyAnalysis.html