Replaced old atoi() with better strtol() #1422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see any actual benefin otherwise. |
There's no big benefit. It's just a little cleanup to remove an obsolete function. |
|
atoi is not obsolete, it is just not recommended any longer :) strtol is better /if/ you add error checking. |
Draft error checking now added. |
seanm
force-pushed
the
atoi
branch
2 times, most recently
from
d7bbd5a
to
e0ecc6a
Compare
tormodvolden
reviewed
May 7, 2024
atoi() gives no opportunity for error checking, strtol() does. Improved error checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atoi() gives no opportunity for error checking, strtol() does. Though I did not actually improve error checking...