-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint to expose lambda init binary, increase fidelity of the kubernetes dev script #10828
Conversation
LocalStack Community integration with Pro 2 files 2 suites 1h 41m 26s ⏱️ Results for commit 13c80a0. ♻️ This comment has been updated with latest results. |
65ba56b
to
2f07712
Compare
2f07712
to
99beca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't speak of the Lambda changes, but these seem reasonable, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these improvements!
99beca1
to
a57c7ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but I have not tested them. For such PRs, it would be helpful to have a "Testing" section with suggested steps to test.
The K8 dev script is great. Unfortunately, it did not work yet as expected:
- It prints "Generated file: configuration.yml" but does not actually generate a file (I had to manually copy/paste the output; maybe that's intended and the output is misleading)
k3d cluster create ...
printsINFO[0003] Prep: Network
and then nothing happens 🤔 A subsequenthelm upgrade ...
fails with cluster unreachable.
I didn't investigate further ...
|
Motivation
We are working on several features which need to download the init binary from LocalStack on demand.
This necessitated the inclusion of an endpoint to expose the init binary.
Also, the kubernetes dev script had some shortcomings, like the pro image not automatically selected, unable to automatically add environment variables, and not exposing a port by default.
For increased usability, I added those features.
Lastly, we now have a check if docker is available before trying to pull / inspect, to avoid needlessly verbose error messages.
Changes
<localstack_host>/_aws/lambda/init
endpoint (GET)python -m localstack.dev.kubernetes
now has new parameters and automatically determines the correct image (although the community image might still be broken and needs more fixing)