Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): remove outdated nextjs app router guide #5862

Merged
merged 1 commit into from
May 29, 2024

Conversation

wangsijie
Copy link
Contributor

@wangsijie wangsijie commented May 14, 2024

Summary

Remove the out-dated "Next.js (App Router)" guide, and replaced with the existing "Next.js (Server Actions)" guide. Fixes #5820

Background:

When we first create the Next.js (App Router) guide, the feature "Server Actions" is still on beta, so we created a seperate Next.js (Server Actions) guide. Now, this feature is not in beta anymore, so it is time to replace the old guide, because it is out-dated.

Testing

Local preview.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented May 14, 2024

COMPARE TO master

Total Size Diff 📉 -9.05 KB

Diff by File
Name Diff
packages/console/src/assets/docs/guides/index.ts 📉 -319 Bytes
packages/console/src/assets/docs/guides/web-next-app-router/README.mdx 📉 -129 Bytes
packages/console/src/assets/docs/guides/web-next-app-router/config.json 📉 -2 Bytes
packages/console/src/assets/docs/guides/web-next-app-router/index.ts 📉 -48 Bytes
packages/console/src/assets/docs/guides/web-next-server-actions/README.mdx 📉 -5.29 KB
packages/console/src/assets/docs/guides/web-next-server-actions/config.json 📉 -19 Bytes
packages/console/src/assets/docs/guides/web-next-server-actions/index.ts 📉 -456 Bytes
packages/console/src/assets/docs/guides/web-next-server-actions/logo.svg 📉 -2.82 KB
packages/console/src/assets/docs/guides/web-next/index.ts 📉 -20 Bytes
packages/integration-tests/src/tests/console/applications/constants.ts 📉 -28 Bytes

@wangsijie wangsijie force-pushed the wangsijie-log-8851-check-nextjs-docs branch from 6a2a823 to dd9b69d Compare May 14, 2024 05:30
@wangsijie wangsijie marked this pull request as draft May 20, 2024 02:08
@wangsijie wangsijie closed this May 24, 2024
@wangsijie wangsijie force-pushed the wangsijie-log-8851-check-nextjs-docs branch from dd9b69d to fb20fc1 Compare May 24, 2024 02:22
@github-actions github-actions bot added size/xs and removed size/xl labels May 24, 2024
@wangsijie wangsijie reopened this May 24, 2024
@wangsijie wangsijie marked this pull request as ready for review May 24, 2024 02:29
@github-actions github-actions bot added size/xl and removed size/xs labels May 24, 2024
@wangsijie wangsijie force-pushed the wangsijie-log-8851-check-nextjs-docs branch from d565446 to 6a5c1c2 Compare May 24, 2024 03:19
@wangsijie wangsijie force-pushed the wangsijie-log-8851-check-nextjs-docs branch from 6a5c1c2 to 11671e1 Compare May 24, 2024 03:43
@charIeszhao charIeszhao merged commit a330310 into master May 29, 2024
27 checks passed
@charIeszhao charIeszhao deleted the wangsijie-log-8851-check-nextjs-docs branch May 29, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

bug: The doc is completely wrong for NextJs App router.
2 participants