smtc-modem-cores #233
Draft
smtc-modem-cores #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthiery
force-pushed
the
lthiery/semtech-sx12xx
branch
5 times, most recently
from
3fb8730
to
34b6d9f
Compare
plaes
reviewed
Mar 26, 2024
lthiery
force-pushed
the
lthiery/semtech-sx12xx
branch
5 times, most recently
from
a1be791
to
15ea2ca
Compare
lthiery
force-pushed
the
lthiery/semtech-sx12xx
branch
from
15ea2ca
to
1d53098
Compare
lthiery
force-pushed
the
lthiery/semtech-sx12xx
branch
from
1d53098
to
a86b882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing Semtech's new reference drivers, I thought it would be interesting to start using them in testing the lora-phy implementation. Full chip support exists in these reference drivers, so it would be further useful for developing sx128x or lr1110 implementations.
Furthermore, a no-async device implementation could be based on this bindgen package.
Anyway, I did the initial scaffolding for bindgen and showing how the "safe" Rust wrapper could be implemented. I wanted to share the current setup for visibility / early comments. The one thing that bothers me is the
concrete_exportmacro. I wonder if there's another solution other than forcing the user to define the macro.