lora-phy: add get_rssi() to RadioKind trait #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe1es
requested review from
lucasgranberg,
plaes,
CBJamo,
Dirbaio and
lthiery
as code owners
|
Could you write an example on how you want to use this code? |
|
What I want is basically the same as this function. With the function, you first check if the RSSI is below a given threshold for a certain duration, and if so, you perform tx(). Otherwise, you try again later. |
plaes
requested changes
Apr 22, 2024
plaes
previously approved these changes
Apr 29, 2024
|
This makes sense to me. I would still like some example code at least for one target on how to use this. It helps us with maintaining the code and it works as documentation too. Also it makes it easier for anyone with the hw to test it. |
|
I added a very simple example for stm32l0 which just keeps logging the current rssi. |
|
Is this PR still a draft or is it ready for final review? |
|
I think this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to do carrier sensing using the current RSSI value. The CAD isn't enough because I want to detect waves besides LoRa. So I added
get_rssi()to theRadioKindtrait and exposed it. I also addedRadioMode::Listenin which the radio keeps listening to a given frequency so that theRegRssiValueregister is updated continuously. I'm not sure if it's ok to add a new RadioMode though.I don't own sx126x chips, so I implemented
get_rssi()only for sx127x and tested on sx1276. I'd appreciate it if someone could implement it for sx126x.