Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In essence, this PR updates
async-profiler
to the recently version 3.0.One main change is that we now don't pull the API from jitpack anymore, but from maven central using the official coordinates (hard to find tbh, but see async-profiler/async-profiler#93 (comment)).
Notable changes:
.so
files, so we don't need to include them manually anymore. However, the path changed, but I guess that's fine.// spark
commentThere are a few things that could be considered following this PR:
-e ctimer
as it doesn't requireperf_events
(Accurate CPU sampling without perf_events async-profiler/async-profiler#855)I tested the changes on linux amd64 and linux arm64.