Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async-profiler to v3.0 #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SirYwell
Copy link

@SirYwell SirYwell commented Feb 8, 2024

In essence, this PR updates async-profiler to the recently version 3.0.

One main change is that we now don't pull the API from jitpack anymore, but from maven central using the official coordinates (hard to find tbh, but see async-profiler/async-profiler#93 (comment)).

Notable changes:

  • This dependency already contains the .so files, so we don't need to include them manually anymore. However, the path changed, but I guess that's fine.
  • For amd64, glibc and musl are now supported with one file (since 3.0).
  • JfrReader was outdated/not able to parse new profiles anymore. I copied the current changes, only keeping the changes with a // spark comment

There are a few things that could be considered following this PR:

I tested the changes on linux amd64 and linux arm64.

@lucko
Copy link
Owner

lucko commented Feb 28, 2024

Happy to merge this, but I think I will wait for v3.1 to drop as there are some commits / bug fixes that have been made since the 3.0 release which I think would be good to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants