Add a new default colour palette #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current default, VGA, the colours differ significantly in lightness. Blue is especially dark and can therefore be difficult to read on a black background. The new default colours have a more uniform lightness, and hand-picked hue and chroma values to make them distinguishable from each other. The foreground colour is white and not grey to increase the contrast of most of the text shown in the terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
With the current default, VGA, the colours differ significantly in lightness. Blue is especially dark and can therefore be difficult to read on a black background.
Proposed changes
The new default colours have a more uniform lightness, and hand-picked hue and chroma values to make them distinguishable from each other. The foreground colour is white and not grey to increase the contrast of most of the text shown in the terminal.
Current and proposed default palette in action
echo; for i in {30..47} {89..107}; do echo $'\u001b'"[${i}m Colour $i "$'\u001b'"[m"; done | column; echoLightness and hue values of the current and proposed default palette
Additional notes
Which palette looks good depends on personal preference, the display, viewing environment, windows shown next to the terminal, and more.
Please test if my change works correctly; I tried to test it myself but strange things happened with and without the commit, perhaps because I have a system-wide LXTerminal, too.