Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshare #217

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Screenshare #217

wants to merge 1 commit into from

Conversation

m1k1o
Copy link
Owner

@m1k1o m1k1o commented Nov 7, 2022

Adding screenshare support to neko.

Things to sort out before merging:

  • Turn off video/audio pipeline and controls when screenshare is active. Turn it back on when it ends.
  • See if data can be directly passed through or must be reencoded.
    • Add support for multiple codecs.
  • Sometimes when starting and stopping screenshare multiple times it does not work - must be reliable.
  • Create GUI.

@m1k1o m1k1o marked this pull request as draft November 7, 2022 20:03
@m1k1o
Copy link
Owner Author

m1k1o commented Jan 29, 2023

First two screenshares works, thrid one does not.

Server:

ERR Incoming unhandled RTP ssrc(1661240182), OnTrack will not be fired. mid RTP Extensions required for Simulcast

Cleint:

Uncaught (in promise) DOMException: Answer tried to set recv when offer did not set send

@innerop
Copy link

innerop commented Apr 11, 2023

What is the use case for this? I wonder if features like this can be included optionally during the build using 'feature flags' to avoid code bloat?

@m1k1o
Copy link
Owner Author

m1k1o commented Apr 11, 2023

This feature is quite lightweight. If some user would like to share something quickly from their local screen. This use case is coming from collaborative space. For me its insteresting as PoC if that can be implemented nicely.

@innerop
Copy link

innerop commented Apr 11, 2023

makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants