[WEB-1177] fix: sub-issues count mutation. #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatishGandham
requested changes
May 20, 2024
There was a problem hiding this comment.
Hi @prateekshourya29 , have you tried updating the parent issues sub_issues_count count property? Wouldn't that be a simpler solution?
Hey @SatishGandham, are you referring to updating it manually? Or we can also use the We can also re-fetch the parent issue details but that would cost us an extra API call for just one property update. |
SatishGandham
approved these changes
May 21, 2024
sriramveeraghanta
pushed a commit
that referenced
this pull request
May 21, 2024
* [WEB-1177] fix: sub-issues count mutation. * chore: refactor sub_issues_count mutation logic. * fix: build errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
sub-issues-countwas not updating upon creating a new sub-issue.Solution
The count wasn't updating because it used a static value (
issue.sub-issues-count) from the issue-detail data without re-fetching it. To fix this, I'm now updating thesub_issues_countdata after every create/ remove/ delete operation in sub issues store.Media
scrnli_5_20_2024_1-37-14.AM.webm
scrnli_5_20_2024_1-36-13.AM.webm
This PR is linked to WEB-1177