Send a response for mute/unmute requests when the player is already in the requested state and add a timeout #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call ret when already in requested mute state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve issues with the server lagging/freezing -- as well as unmuting pre-emptively.
The pre-emptive unmuting problem occurs because unmute requests sent when the player is already unmuted (such as an unmute request at round start and then at playerspawn) retry constantly until the player can be unmuted (as in, as soon as the player gets muted again, the previous unmute request that failed finally goes through). This seems to be because gmod never receives a return response for mute requests in which the player is already in the correct state. This pull request sends a response in such cases.
I believe this was also the cause of the server lagging/freezing. In any case, the timeout should resolve that issue if it remains.
Fixes #11