Fix handling of unknown characters in SVG output. (mathjax/MathJax#3224) #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the handling of the width of characters that are not in the MathJax fonts in SVG mode that could lead to overlapping characters. The SVG wrapper's
toSVG()code has been reordered to make this work properly. The handling of unknown characters has been moved to the top, andif-then-elsehas been broken into separateif-thenwith returns, with the width of previous unknown characters being taken properly into account (which was what wasn't being done).This only affects text that is all in the same MathML node, so you can test using
\text{aaa 中文 bbbb}for theunknownandpsections of the code. To get actest, you need to use themathjax-texfont with\text{aaa\U{220C}bbb}.Resolves issue mathjax/MathJax#3224.