Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent linebreaking from crashing on empty containers. (mathjax/MathJax#3232) #1093

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 19, 2024

This PR fixes a problem in the LinebreakVisitor object where malignmark or maligngroup elements (which have no children) cause a "Math output error" due to an attempt to use childNodes[0] when that is null.

Resolves issue mathjax/MathJax#3232.

@dpvc dpvc requested a review from zorkow May 19, 2024 17:07
@dpvc dpvc added this to the v4.0 milestone May 19, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 51392bc into develop Jun 4, 2024
@dpvc dpvc deleted the issue3232 branch June 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants