Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QtLocation Plugin Improvements #11532

Closed
wants to merge 1 commit into from
Closed

Conversation

HTRamsey
Copy link
Collaborator

@HTRamsey HTRamsey commented May 14, 2024

  • Add QGeoTiledMap & QGeoFileTileCache overrides
  • Improve control of maps caching
  • Add engineReady signal
  • Add improved network request control for downloading tiles
  • Reduce total amount of network access managers created
  • Add logging capability to each existing file and new ones
  • Implement fetching enabled and fetching initialized
  • Removed timer and uses internal QNetworkRequest timeout
  • Fixes handling of file resources in QGeoMapReplyQGC
  • Fixes finished/error signals in QGeoMapReplyQGC
  • Simplify elevation handling in QGeoMapReplyQGC
  • Removed unused geocoding
  • Converted many dynamic object to static
  • Prep for reading custom maps from user provided json file
  • Allow Map Provider specific cameracapbilities (like bing limited to 20x zoom)
  • Moved a couple of generic functions to QGCApplication
  • Optimized parameters with QStringView
  • Consolidated QGCMapEngineManager with MapEngineManager Singleton and removed tool inheritance

Future TODO:

  • Hook QGCTileCacheWorker into QGeoTileFetcherQGC and QGeoFileTileCacheQGC
  • Allow user provided json of custom maps
  • Custom tile downloader with QGCNetworkAccessManager
  • Custom Qml Map with QGCqdeclarativegeomap, provides access to plugin
  • QGCCacheWorker optimizations?
  • Hook terrain queries & 3dviewer into existing tile classes
  • Override/utitilize remaining functions and signals/slots from QtLocationPlugin classes
  • QDeclarativeCircleMapItem for geofence

@HTRamsey HTRamsey requested review from mrpollo May 14, 2024 12:34
@mrpollo mrpollo requested a review from bkueng May 16, 2024 17:15
@mrpollo
Copy link
Member

mrpollo commented May 16, 2024

I'm wondering if you have a few minutes to review this one @bkueng

@bkueng
Copy link
Member

bkueng commented May 29, 2024

Sorry, I currently don't have the time to give this the proper review it deserves.
I very much appreciate the good work you're doing @HTRamsey

@HTRamsey
Copy link
Collaborator Author

@bkueng Is this something that I should break down into smaller PRs and this PR would be the eventual end goal, or is this just something out of scope? Either way works for me, I only provided it as I've personally used something similar for years without issue and it provides some cool possibilities to expand on it.

@bkueng
Copy link
Member

bkueng commented May 30, 2024

Yes splitting it up would help, but I'm not really familiar with that part of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants