-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend T-Deck variant.h to improve readability #3926
Conversation
Changes to improve readability of T-Deck TFT: Set T-Deck screen colour to white rather than green. Increase default brightness to 200
I don't think there's a need to change the default brightness level considering you can now change the brightness level using the keyboard. I also don't think we should change the color scheme for one person's perceived readability level. If anything, an option to select what you are proposing in the display configs seems to be more appropriate |
I had previously achieved the same result in a different way. When I posted images on a Facebook group, there was significant interest. |
Increasing the default brightness will also increase the power consumption of the TFT display and thus reduce the runtime on batteries. As already suggested you can use the keyboard control to adapt the brightness, but I would not touch the default as not all users know how to change the brightness. |
Ok, I'll take the adjustable brightness comment. Thoughts on the colour change? Everyone that has seen it prefers white text as it is much more readable in bright sunlight. I am happy to raise a retrospective enhancement request, to use it to gauge user opinions? |
I don’t see the need to change it. There’s been little to no issue so far. If there’s a personal preference, then it would be something folks can manually compile for themselves. |
I dont agree with that statement. I’m actually running custom builds now only to have a white text… For people using devices in sunny places there is no way to see anything on this screen even at full brightness… white does make it more readable… If I understood how to code this I would even go with an actual white background and black text which is the most readable outdoor in the sun… |
I've already made a change to support it, and submitted the pull request. |
And I don’t agree with yours. I use mine outdoors. Is it sometimes difficult to see? Sure, as is any screen. But I don’t think it’s as difficult as is being made out to be. |
I think it's sad to dismiss people's opinion based on your own and not to offer options... |
I’m not dismissing your opinion, simply stating I don’t agree with it. As you had just done with yours regarding mine as noted above. I in fact live in a “scorching desert burned by the sun”. Also, I even tested this change and personally see no difference in the readability in the sun. Personally I think the green sticks out a little more to be honest and is easier to see than the white. Also, I’ve suggested making it a config option. It’s not so easy to do so, so probably not a route that would be taken. Personally, I don’t think we should be making changes because a select few want something different. If this was as big as an issue as it’s being made out to be in this discussion, we would have seen numerous complaints about this beforehand. We have not. Lastly, I’m bit a decision maker. Merely offering my opinion as are you. Surely there shouldn’t be an issue with that just because I don’t agree with you. |
Changes to improve readability of T-Deck TFT:
Set T-Deck screen colour to white rather than green. Increase default brightness to 200