Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen changes from time deltas to timestamps after 15 minutes #3935

Merged
merged 8 commits into from
May 21, 2024

Conversation

todd-herbert
Copy link
Contributor

@todd-herbert todd-herbert commented May 19, 2024

Changes the time deltas to timestamps in some situations, for E-Ink displays. extended to all displays

Conditions:

  • Timezone must be set
  • Timestamp must be at least 15 minutes in the past. Until this point, time delta is displayed

Impact:

  • E-Ink UI is more static, fewer refreshes: avoids refreshing every minute to update time-deltas
  • If configured correctly (if timezone set), much higher screen-timeout values are suitable (longer before screensaver appears)

Allows users to disable the E-Ink screensaver, by setting screen timeout to zero.
If disabled, a cautionary message is printed to the on-screen log buffer at startup.

@caveman99
Copy link
Sponsor Member

Looking good to me. One point: is it useful to implement alternating behaviour for eInk only? i like the 15 minute cutoff for the time display, why not just enable it for all displays?

@todd-herbert
Copy link
Contributor Author

Can certainly enable it everywhere if you think it's useful. It was just me trying to tread lightly!

@todd-herbert todd-herbert marked this pull request as draft May 19, 2024 11:28
@todd-herbert todd-herbert changed the title E-Ink Timestamps Screen changes from time deltas to timestamps after 15 minutes May 19, 2024
@todd-herbert todd-herbert marked this pull request as ready for review May 19, 2024 12:26
@todd-herbert todd-herbert marked this pull request as draft May 20, 2024 11:30
@todd-herbert
Copy link
Contributor Author

Just making minor adjustments

@todd-herbert todd-herbert marked this pull request as ready for review May 20, 2024 12:39
@thebentern thebentern merged commit a12b992 into meshtastic:master May 21, 2024
80 checks passed
@todd-herbert todd-herbert deleted the eink-timestamp branch May 21, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants