Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook on web crawling #2720

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

WilliamEspegren
Copy link

@WilliamEspegren WilliamEspegren commented May 19, 2024

Why are these changes needed?

Lacking web crawling examples in both notebooks and the docs/Example.md

Checks

Not any applicable right?

I referred to a previous pull request for inspiration while creating this notebook example for Spider. This PR provided a helpful reference for structure and content, which I have adapted to fit the specific requirements of Spider.

Twitter handle: @WilliamEspegren

@WilliamEspegren
Copy link
Author

@microsoft-github-policy-service agree

@WilliamEspegren WilliamEspegren marked this pull request as ready for review May 20, 2024 14:04
@sonichi
Copy link
Collaborator

sonichi commented May 21, 2024

Thanks. Would you like the notebook to be rendered on the website? If so, https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website is the guide.

@WilliamEspegren
Copy link
Author

Thanks. Would you like the notebook to be rendered on the website? If so, https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website is the guide.

Yes please! I will look into this

@WilliamEspegren
Copy link
Author

@sonichi This notebook will be rendered on the website right?

@sonichi
Copy link
Collaborator

sonichi commented May 25, 2024

@sonichi This notebook will be rendered on the website right?

Some metadata needs to be added for it to render. It's OK to do it in a separate PR if you like.

@sonichi sonichi enabled auto-merge May 25, 2024 00:48
Copy link

gitguardian bot commented May 25, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10493810 Triggered Generic Password 49e8053 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 501610b notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 49e8053 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 501610b notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 49e8053 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 501610b notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

auto-merge was automatically disabled May 26, 2024 16:09

Head branch was pushed to by a user without write access

@WilliamEspegren
Copy link
Author

@sonichi Sorry for that, now it is formatted correctly and passes the checks

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants