Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(recipes): create package with initial implementation (moved from /apps) #31386

Merged
merged 10 commits into from
May 24, 2024
Merged

feat(recipes): create package with initial implementation (moved from /apps) #31386

merged 10 commits into from
May 24, 2024

Conversation

sopranopillow
Copy link
Contributor

Previous Behavior

Recipes was using an app to act as a standalone app.

New Behavior

As per @Hotell's recommendation I've moved this into a package so it can just be added to the docsite's dependencies and Alakazam it works perfectly! (see https://github.com/microsoft/fluentui/pull/27747/files#r1183520143)

I'll need to cleanup the app and remove it, but this PR basically copies over the files from the app to a new package.

Related Issue(s)

@sopranopillow sopranopillow self-assigned this May 15, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 15, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 581 634 5000
Button mount 312 316 5000
Field mount 1185 1145 5000
FluentProvider mount 733 711 5000
FluentProviderWithTheme mount 93 94 10
FluentProviderWithTheme virtual-rerender 33 35 10
FluentProviderWithTheme virtual-rerender-with-unmount 79 74 10
MakeStyles mount 881 874 50000
Persona mount 1850 1805 5000
SpinButton mount 1431 1529 5000
SwatchPicker mount 1630 1597 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 83 72 1.15:1
PortalMinimalPerf.default 94 85 1.11:1
LoaderMinimalPerf.default 189 176 1.07:1
TreeMinimalPerf.default 494 462 1.07:1
ButtonSlotsPerf.default 310 292 1.06:1
ReactionMinimalPerf.default 223 211 1.06:1
IconMinimalPerf.default 416 393 1.06:1
ChatWithPopoverPerf.default 202 192 1.05:1
ImageMinimalPerf.default 233 222 1.05:1
ListMinimalPerf.default 315 301 1.05:1
TextMinimalPerf.default 202 192 1.05:1
DropdownManyItemsPerf.default 401 384 1.04:1
AlertMinimalPerf.default 163 158 1.03:1
CarouselMinimalPerf.default 267 260 1.03:1
FormMinimalPerf.default 222 216 1.03:1
ProviderMinimalPerf.default 209 203 1.03:1
SplitButtonMinimalPerf.default 2268 2197 1.03:1
BoxMinimalPerf.default 199 195 1.02:1
ButtonMinimalPerf.default 90 88 1.02:1
ChatDuplicateMessagesPerf.default 153 150 1.02:1
DividerMinimalPerf.default 210 205 1.02:1
DropdownMinimalPerf.default 1445 1412 1.02:1
EmbedMinimalPerf.default 1888 1852 1.02:1
HeaderMinimalPerf.default 206 202 1.02:1
LayoutMinimalPerf.default 200 197 1.02:1
ListCommonPerf.default 399 393 1.02:1
ListNestedPerf.default 336 328 1.02:1
MenuButtonMinimalPerf.default 944 928 1.02:1
PopupMinimalPerf.default 351 344 1.02:1
RadioGroupMinimalPerf.default 266 261 1.02:1
AnimationMinimalPerf.default 291 289 1.01:1
ButtonOverridesMissPerf.default 676 669 1.01:1
DatepickerMinimalPerf.default 3545 3512 1.01:1
ItemLayoutMinimalPerf.default 705 696 1.01:1
ListWith60ListItems.default 369 364 1.01:1
ProviderMergeThemesPerf.default 641 637 1.01:1
RefMinimalPerf.default 112 111 1.01:1
TableManyItemsPerf.default 1100 1093 1.01:1
AttachmentMinimalPerf.default 74 74 1:1
ChatMinimalPerf.default 426 426 1:1
DialogMinimalPerf.default 455 454 1:1
GridMinimalPerf.default 179 179 1:1
HeaderSlotsPerf.default 460 461 1:1
MenuMinimalPerf.default 496 495 1:1
SegmentMinimalPerf.default 194 194 1:1
CustomToolbarPrototype.default 1470 1466 1:1
ToolbarMinimalPerf.default 531 529 1:1
AvatarMinimalPerf.default 108 109 0.99:1
CheckboxMinimalPerf.default 1121 1129 0.99:1
FlexMinimalPerf.default 154 155 0.99:1
InputMinimalPerf.default 540 544 0.99:1
SkeletonMinimalPerf.default 195 197 0.99:1
StatusMinimalPerf.default 385 388 0.99:1
TableMinimalPerf.default 228 231 0.99:1
LabelMinimalPerf.default 221 225 0.98:1
TextAreaMinimalPerf.default 280 287 0.98:1
AttachmentSlotsPerf.default 624 641 0.97:1
SliderMinimalPerf.default 728 749 0.97:1
TooltipMinimalPerf.default 1234 1291 0.96:1
CardMinimalPerf.default 296 311 0.95:1
RosterPerf.default 1506 1595 0.94:1
VideoMinimalPerf.default 415 453 0.92:1
TreeWith60ListItems.default 74 84 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 623 620 5000
Breadcrumb mount 1679 1680 1000
Checkbox mount 1675 1713 5000
CheckboxBase mount 1523 1451 5000
ChoiceGroup mount 2938 2982 5000
ComboBox mount 655 691 1000
CommandBar mount 6425 6538 1000
ContextualMenu mount 11542 11786 1000
DefaultButton mount 795 801 5000
DetailsRow mount 2243 2221 5000
DetailsRowFast mount 2223 2210 5000
DetailsRowNoStyles mount 2067 2040 5000
Dialog mount 2660 2782 1000
DocumentCardTitle mount 216 224 1000
Dropdown mount 2029 1979 5000
FocusTrapZone mount 1131 1117 5000
FocusZone mount 1061 1076 5000
GroupedList mount 41706 41807 2
GroupedList virtual-rerender 17949 19990 2
GroupedList virtual-rerender-with-unmount 50397 50470 2
GroupedListV2 mount 225 223 2
GroupedListV2 virtual-rerender 202 213 2
GroupedListV2 virtual-rerender-with-unmount 237 224 2
IconButton mount 1110 1147 5000
Label mount 327 344 5000
Layer mount 2784 2749 5000
Link mount 396 385 5000
MenuButton mount 1010 970 5000
MessageBar mount 21213 21280 5000
Nav mount 2033 1988 1000
OverflowSet mount 810 784 5000
Panel mount 1859 1824 1000
Persona mount 735 730 1000
Pivot mount 881 924 1000
PrimaryButton mount 929 925 5000
Rating mount 4707 4717 5000
SearchBox mount 900 933 5000
Shimmer mount 1853 1888 5000
Slider mount 1346 1339 5000
SpinButton mount 2998 2928 5000
Spinner mount 392 387 5000
SplitButton mount 1855 1871 5000
Stack mount 415 416 5000
StackWithIntrinsicChildren mount 841 844 5000
StackWithTextChildren mount 2659 2645 5000
SwatchColorPicker mount 6343 6370 5000
TagPicker mount 1450 1478 5000
Text mount 373 382 5000
TextField mount 932 938 5000
ThemeProvider mount 826 844 5000
ThemeProvider virtual-rerender 578 574 5000
ThemeProvider virtual-rerender-with-unmount 1303 1280 5000
Toggle mount 606 600 5000
buttonNative mount 185 192 5000

@sopranopillow sopranopillow marked this pull request as ready for review May 22, 2024 16:20
Hotell
Hotell reviewed May 23, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
Hotell
Hotell reviewed May 23, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@sopranopillow sopranopillow requested a review from Hotell May 24, 2024 06:11
@Hotell Hotell changed the title feat: Add recipes feat(recipes): create package with initial implementation (moved from /apps) May 24, 2024
@sopranopillow sopranopillow merged commit fe9c351 into microsoft:master May 24, 2024
21 checks passed
@sopranopillow sopranopillow deleted the recipes-to-package branch May 24, 2024 20:02
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 28, 2024
@marcosmoura
Merge branch 'master' into feat/react-drawer/allow-aside-tag
f7f0a2b 
* master: (49 commits)
  Update focus order in sankey chart for vertical navigation (microsoft#31469)
  chore: use new performant 'type-check' for v9 libaries (microsoft#31454)
  applying package updates
  fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324)
  chore: re-enable lint rule (microsoft#31459)
  feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474)
  feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386)
  applying package updates
  applying package updates
  chore: revert globals changes (microsoft#31470)
  (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201)
  chore:(docs) Update and migrate component implementation guide (microsoft#31398)
  disallow all globals in Fluent v9 (microsoft#30967)
  chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387)
  fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465)
  fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463)
  applying package updates
  applying package updates
  applying package updates
  Update IconDirectionContextProvider import to import from specific path (microsoft#31006)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@Hotell Hotell Hotell approved these changes

@JustSlone JustSlone JustSlone approved these changes

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

Assignees

@sopranopillow sopranopillow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sopranopillow @fabricteam @Hotell @JustSlone