Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-components) Export component definitions from rollup bundle #31403

Conversation

radium-v
Copy link
Contributor

Previous Behavior

The index-rollup bundle generated didn't include the component definitions.

New Behavior

The generated dist/web-components.js and dist/web-components.min.js now focus on defining the components in the browser.

@radium-v radium-v requested a review from a team as a code owner May 16, 2024 22:34
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on setting the default theme.

packages/web-components/src/index-rollup.ts Outdated Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2024

📊 Bundle size report

✅ No changes found

Copy link

codesandbox-ci bot commented May 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@chrisdholt chrisdholt enabled auto-merge (squash) May 24, 2024 23:34
@radium-v radium-v force-pushed the users/radium-v/web-components-bundle-export branch from 0b063a8 to ae78eea Compare May 31, 2024 18:26
@chrisdholt chrisdholt merged commit 8820c13 into microsoft:master May 31, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants