Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:(docs) Migrating Keeping up with review requests #31414

Merged

Conversation

mltejera
Copy link
Contributor

@mltejera mltejera commented May 17, 2024

Migrating Keeping up with review requests from the wiki. Made no file changes.

Copy link

codesandbox-ci bot commented May 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 636 624 5000
Button mount 309 292 5000
Field mount 1159 1130 5000
FluentProvider mount 700 715 5000
FluentProviderWithTheme mount 84 79 10
FluentProviderWithTheme virtual-rerender 36 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 79 10
MakeStyles mount 871 865 50000
Persona mount 1764 1788 5000
SpinButton mount 1366 1421 5000
SwatchPicker mount 1542 1525 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 104 85 1.22:1
LoaderMinimalPerf.default 204 179 1.14:1
ButtonMinimalPerf.default 97 86 1.13:1
FlexMinimalPerf.default 166 147 1.13:1
ChatDuplicateMessagesPerf.default 170 152 1.12:1
TextAreaMinimalPerf.default 313 290 1.08:1
SegmentMinimalPerf.default 207 194 1.07:1
TableMinimalPerf.default 249 232 1.07:1
VideoMinimalPerf.default 455 427 1.07:1
AvatarMinimalPerf.default 115 108 1.06:1
TextMinimalPerf.default 214 201 1.06:1
AttachmentMinimalPerf.default 82 78 1.05:1
FormMinimalPerf.default 229 218 1.05:1
InputMinimalPerf.default 555 530 1.05:1
ButtonOverridesMissPerf.default 714 687 1.04:1
CarouselMinimalPerf.default 271 261 1.04:1
ChatMinimalPerf.default 457 441 1.04:1
DialogMinimalPerf.default 446 434 1.03:1
HeaderMinimalPerf.default 209 202 1.03:1
ImageMinimalPerf.default 240 234 1.03:1
ListMinimalPerf.default 319 311 1.03:1
TreeMinimalPerf.default 490 476 1.03:1
AlertMinimalPerf.default 155 152 1.02:1
AttachmentSlotsPerf.default 669 655 1.02:1
CheckboxMinimalPerf.default 1166 1140 1.02:1
HeaderSlotsPerf.default 458 449 1.02:1
SkeletonMinimalPerf.default 209 204 1.02:1
SplitButtonMinimalPerf.default 2290 2253 1.02:1
IconMinimalPerf.default 390 384 1.02:1
TableManyItemsPerf.default 1107 1085 1.02:1
DropdownManyItemsPerf.default 385 382 1.01:1
DropdownMinimalPerf.default 1434 1423 1.01:1
MenuMinimalPerf.default 516 512 1.01:1
MenuButtonMinimalPerf.default 981 972 1.01:1
PopupMinimalPerf.default 352 350 1.01:1
PortalMinimalPerf.default 83 82 1.01:1
ProviderMinimalPerf.default 198 196 1.01:1
ReactionMinimalPerf.default 218 216 1.01:1
StatusMinimalPerf.default 396 393 1.01:1
AnimationMinimalPerf.default 294 295 1:1
CardMinimalPerf.default 310 311 1:1
ChatWithPopoverPerf.default 198 198 1:1
DatepickerMinimalPerf.default 3584 3596 1:1
DividerMinimalPerf.default 202 203 1:1
ItemLayoutMinimalPerf.default 698 697 1:1
RadioGroupMinimalPerf.default 257 256 1:1
ToolbarMinimalPerf.default 557 557 1:1
BoxMinimalPerf.default 192 193 0.99:1
SliderMinimalPerf.default 738 749 0.99:1
CustomToolbarPrototype.default 1504 1525 0.99:1
ButtonSlotsPerf.default 315 320 0.98:1
EmbedMinimalPerf.default 1861 1898 0.98:1
LayoutMinimalPerf.default 203 207 0.98:1
ListWith60ListItems.default 372 378 0.98:1
RosterPerf.default 1562 1592 0.98:1
TooltipMinimalPerf.default 1269 1290 0.98:1
AccordionMinimalPerf.default 89 92 0.97:1
ListNestedPerf.default 330 339 0.97:1
ProviderMergeThemesPerf.default 640 662 0.97:1
LabelMinimalPerf.default 217 225 0.96:1
RefMinimalPerf.default 103 108 0.95:1
GridMinimalPerf.default 183 195 0.94:1
ListCommonPerf.default 388 418 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 649 5000
Breadcrumb mount 1654 1670 1000
Checkbox mount 1702 1707 5000
CheckboxBase mount 1485 1470 5000
ChoiceGroup mount 2988 2992 5000
ComboBox mount 704 676 1000
CommandBar mount 6486 6488 1000
ContextualMenu mount 11650 11723 1000
DefaultButton mount 795 787 5000
DetailsRow mount 2254 2248 5000
DetailsRowFast mount 2224 2285 5000
DetailsRowNoStyles mount 2081 2085 5000
Dialog mount 2789 2775 1000
DocumentCardTitle mount 224 228 1000
Dropdown mount 1998 2030 5000
FocusTrapZone mount 1126 1162 5000
FocusZone mount 1079 1093 5000
GroupedList mount 42066 41871 2
GroupedList virtual-rerender 18149 20233 2
GroupedList virtual-rerender-with-unmount 50836 51051 2
GroupedListV2 mount 223 226 2
GroupedListV2 virtual-rerender 215 215 2
GroupedListV2 virtual-rerender-with-unmount 236 229 2
IconButton mount 1125 1110 5000
Label mount 338 343 5000
Layer mount 2751 2712 5000
Link mount 399 390 5000
MenuButton mount 993 975 5000
MessageBar mount 21288 21219 5000
Nav mount 2011 2078 1000
OverflowSet mount 773 779 5000
Panel mount 1804 1821 1000
Persona mount 761 745 1000
Pivot mount 907 894 1000
PrimaryButton mount 920 936 5000
Rating mount 4755 4780 5000
SearchBox mount 932 946 5000
Shimmer mount 1928 1890 5000
Slider mount 1349 1344 5000
SpinButton mount 3032 2975 5000
Spinner mount 386 387 5000
SplitButton mount 1890 1892 5000
Stack mount 402 401 5000
StackWithIntrinsicChildren mount 850 857 5000
StackWithTextChildren mount 2683 2674 5000
SwatchColorPicker mount 6387 6316 5000
TagPicker mount 1499 1477 5000
Text mount 372 371 5000
TextField mount 932 933 5000
ThemeProvider mount 849 830 5000
ThemeProvider virtual-rerender 583 583 5000
ThemeProvider virtual-rerender-with-unmount 1290 1299 5000
Toggle mount 613 618 5000
buttonNative mount 193 190 5000

@tudorpopams tudorpopams self-requested a review May 21, 2024 12:03
@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@mltejera mltejera merged commit ac28ca0 into microsoft:master May 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants