Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-combobox]Fix to not shrink checkbox even if option text is very long #31418

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hnisiji
Copy link

@hnisiji hnisiji commented May 19, 2024

Previous Behavior

As shown in the screenshot below, ComboBox option's checkbox shrinks for long text.

スクリーンショット 2024-05-19 10 52 16

New Behavior

Checkbox does not shrink even if option text is very long.

Previous Behavior New Behavior
2024-05-19.10.50.57.mov
2024-05-19.10.47.16.mov

Related Issue(s)

  • Fixes #

@hnisiji hnisiji requested review from smhigley and a team as code owners May 19, 2024 02:05
Copy link

codesandbox-ci bot commented May 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@hnisiji hnisiji changed the title Fixed checkbox not shrinking even if option text is very long [ComboBox]Fix to not shrink checkbox even if option text is very long May 20, 2024
@hnisiji hnisiji changed the title [ComboBox]Fix to not shrink checkbox even if option text is very long [ComboBox]Fix to not shrink checkbox even if option text is very long May 20, 2024
@hnisiji hnisiji changed the title [ComboBox]Fix to not shrink checkbox even if option text is very long [react-combobox]Fix to not shrink checkbox even if option text is very long May 20, 2024
@spmonahan
Copy link
Contributor

@hnisiji I just kicked off the pipeline so we can run tests, etc but I did notice you'll need to add a change file. To do this, from the repo root run:

yarn change

and follow the prompts.

@hnisiji
Copy link
Author

hnisiji commented May 20, 2024

@microsoft-github-policy-service agree

@hnisiji
Copy link
Author

hnisiji commented May 20, 2024

@spmonahan
Thank you for reviewing! I added change file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants