-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed default value of the startInterval to 5s #47799
Merged
thaJeztah
merged 1 commit into
moby:master
from
j2walker:47648-dameon-health-start-interval-default-value-fix
Jun 10, 2024
Merged
Changed default value of the startInterval to 5s #47799
thaJeztah
merged 1 commit into
moby:master
from
j2walker:47648-dameon-health-start-interval-default-value-fix
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2walker
changed the title
Changed default value of the startInterval to 5s
Changed default value of the startInterval to 5s Signed-off-by: Jack Walker <jack@bunkey.org>
May 5, 2024
j2walker
changed the title
Changed default value of the startInterval to 5s Signed-off-by: Jack Walker <jack@bunkey.org>
Changed default value of the startInterval to 5s
May 5, 2024
j2walker
force-pushed
the
47648-dameon-health-start-interval-default-value-fix
branch
from
May 5, 2024 15:57
03f6dea
to
e7fe35c
Compare
vvoland
requested changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; except the small typo 😅
coolljt0725
reviewed
May 7, 2024
Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Jack Walker <90711509+j2walker@users.noreply.github.com>
thaJeztah
force-pushed
the
47648-dameon-health-start-interval-default-value-fix
branch
from
June 10, 2024 11:24
e7fe35c
to
c514952
Compare
thaJeztah
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vvoland PTAL |
vvoland
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/runtime
impact/changelog
kind/bugfix
PR's that fix bugs
process/cherry-pick/26.1
status/4-merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Changed the startInterval default value to be 5s
- How I did it
Added a new variable named
defaultStartInterval
and set it to 5s. Before, the default value was set to proveInterval by accident.- How to verify it
Run the container's monitoring thread and check if the startInterval's default value is 5s instead of the original 30s.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)