Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus2PM Support #1388

Merged
merged 11 commits into from
Jun 10, 2024
Merged

Plus2PM Support #1388

merged 11 commits into from
Jun 10, 2024

Conversation

markirb
Copy link
Collaborator

@markirb markirb commented May 17, 2024

This creates a PR from timo's WIP for better overview and discussions

Current Issues

  • Revert to stock FW is currently not possible
    This manifests itself that when stock fw is uploaded, the device boots into old firmware. most likely we override some factory default which is not there afterwards. this can be config0.json, as it is notably NOT shipped with stock fw update
    Fixed: this is because the i2c needs to be set in conf according to the model save in shelly partition, otherwise bootloop will occur or revert on OTA downgrade
  • power measurement didn't work properly (prerequisite for Window covering)
  • PM calibration values from nvs not yet read (are there any?)
  • revision detection (there at least two hardware revision out there, with different pinouts), this one only works for latest HW REV
  • PM Calibration value make no sense when writing to ADE registers so not used currently

@markirb markirb marked this pull request as draft May 17, 2024 12:57
@markirb markirb changed the title PlusPM2 Support Plus2PM Support May 17, 2024
@markirb markirb force-pushed the plus2pm branch 4 times, most recently from c50b2ef to 18d6e44 Compare May 18, 2024 05:58
@markirb markirb marked this pull request as ready for review June 8, 2024 08:30
@rrunner83
Copy link

will it be possible to use roller shutter mode as well on the Plus2PM?
somehow its not mentioned in the compatibility list. thanks for info!

@markirb
Copy link
Collaborator Author

markirb commented Jun 9, 2024

Should be possible though I cannot test it myself. Waiting until confirmed

@markirb markirb merged commit beb1b62 into master Jun 10, 2024
38 checks passed
@markirb markirb deleted the plus2pm branch June 10, 2024 17:32
@rrunner83
Copy link

i have the hardware and could test it. but i can't find the firmware for the shelly.. could you send me the link pls?

@markirb
Copy link
Collaborator Author

markirb commented Jun 11, 2024

https://github.com/mongoose-os-apps/shelly-homekit/releases/tag/2.12.0-beta3

@arnetm
Copy link

arnetm commented Jun 12, 2024

I just uploaded the Plus2PM zip, and confirmed working. Roller shutter mode + calibrate works perfectly. Kudos!

@hejsiri
Copy link

hejsiri commented Jun 12, 2024

Shelly+ 2PM works like a garage door. Great news, @markirb good job :)

 IMG_4629 Duży  IMG_4631 Duży  IMG_4632 Duży

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants