Added --silent flag to silence console logging. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moroshko
reviewed
Jan 13, 2023
There was a problem hiding this comment.
Thanks @jake-chapman-mark43, just a small comment, and could you also update the README please?
| .option("-c, --config", "Path to config file") | ||
| .example("-c /path/to/react-scanner.config.js") | ||
| .action((options) => { | ||
| const configPath = path.resolve(process.cwd(), options.config); | ||
| const configDir = path.dirname(configPath); | ||
| const config = require(configPath); | ||
| run(config, configDir, "cli"); | ||
| run(config, configDir, "cli", options.silent); |
There was a problem hiding this comment.
I'd probably convert the params to an object at this point. What do you think?
|
@jake-chapman-mark43 @moroshko I liked the solution, do we have a forecast for a version with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a cli tool for some stuff at work, and the output is messing with our output. Added a simple
--silentflag to silence any of the logging. Not sure your exact thoughts on--silentsuppressing theconsole.error, I've seen libs do either silence everything or have a separate log-level and a silence-errors option.Works for what I need, but if you have any feedback or suggestions on something a little more flexible, I'm all ears.