Add FXIOS-8946 - Show lock icon when url is displayed #20265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatswinnie
reviewed
May 17, 2024
| @@ -21,6 +21,7 @@ public struct StandardImageIdentifiers { | |||
| public static let bookmarkBadgeFillBlue50 = "bookmarkBadgeFillMediumBlue50" | |||
| public static let crossCircleFill = "crossCircleFillMedium" | |||
| public static let cross = "crossMedium" | |||
| public static let lock = "lockMedium" | |||
There was a problem hiding this comment.
If you add the lock icon name here you should also add the image to Client.
There was a problem hiding this comment.
It's already there.
| let shouldAdjustForNonEmpty = !isURLTextFieldEmpty && !isTextFieldFocused | ||
|
|
||
| if shouldAdjustForOverflow { | ||
| updateURLTextFieldLeadingConstraint(equalTo: iconContainerStackView.leadingAnchor, constant: iconContainerStackView.frame.width * 0.5) |
There was a problem hiding this comment.
Where is the magic number of 0.5 coming from?
There was a problem hiding this comment.
It's for setting the leading constraint of the urlTextField to the middle of iconContainerStackView, in order to hide de elipsis. Equivalent would be iconContainerStackView.frame.width / 2.
There was a problem hiding this comment.
Does that work when the user is using a tiny or huge font size as well??
thatswinnie
approved these changes
May 21, 2024
Client.app: Coverage: 31.06
Generated by 馃毇 Danger Swift against f506aef |
|
This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 馃檹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Tickets
Jira ticket
Github issue
馃挕 Description
urlTextFieldis not in editing mode.馃摑 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)