Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-9151 Tab count log message #20276

Merged
merged 1 commit into from
May 21, 2024

Conversation

mattreaganmozilla
Copy link
Collaborator

馃摐 Tickets

Jira ticket
Github issue

馃挕 Description

Minor update to tab count log message to make the output more clear for multi-window users:

1 window ex:
"Tab manager is preserving 2 tabs (1 window)"

>1 window ex:
"Tab manager is preserving 2 tabs (of 3 total tabs across 2 windows)"

馃摑 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mattreaganmozilla mattreaganmozilla requested a review from a team as a code owner May 15, 2024 19:00
@mobiletest-ci-bot
Copy link

Warnings
鈿狅笍 Variable 'crossCircleFill' in Medium is out of alphabetical order.
鈿狅笍 Variable 'cross' in Medium is out of alphabetical order.
Messages
馃摉 Project coverage: 32.34%
馃摉 Edited 1 files
馃摉 Created 0 files

Client.app: Coverage: 30.96

File Coverage
TabManagerImplementation.swift 29.19% 鈿狅笍

Generated by 馃毇 Danger Swift against d799b23

@mattreaganmozilla mattreaganmozilla merged commit 1d87a05 into mozilla-mobile:main May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants