Add FXIOS-9064 ⁃ Investigate logic of "Open link in external app""

[dicarobinho]

📜 Tickets

Jira ticket
Github issue

💡 Description

Added a new option under General Settings -> Open Links In Apps
For URL schemes like "http", "https", "blob", "file", user will have the option to be automatically redirected to the external apps or not.
"By default", WKWebView redirect the user to the external apps, where is possible.

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[dicarobinho]

Here is a short demo with the changes.
⬇️
https://github.com/mozilla-mobile/firefox-ios/assets/61138287/65cf22d1-e17d-407b-87fa-4f5122d24875

[nbhasin2]

Could we get a copy review on these along with screenshot @dicarobinho

[nbhasin2]

or if @afurlan-firefox gives the go ahead for strings then I am okay as well otherwise its best to get these double checked

[dicarobinho]

The setting title is from the Android app. Here is how them look.

[ewachowiak]

• Yes, keep the same string as Android but it should be "Open Links in Apps" (lowercase i) to be proper title case
• This new option does not require any subcopy so please remove "When pressing links"
• For the two options above this, the subcopy should not be in title case. Can we change to sentence case? So the new strings will be
• "When opening Firefox"
• "When long-pressing links"
  This will help us resolve some outstanding UX debt. Thank you.

[afurlan-firefox]

Hi! I wanted to add some context on the option. There is a small difference in between the Android and iOS behavior.
In iOS, the option means:

• If On -> Apple will decide what to do. Meaning, it is not always opening the link in external app. It will be around 95% of the cases but not "always", like it is in Android.
• If Off -> Firefox will override the Apple behavior and always open the links inside inside the navigator.

@nbhasin2 can add more context, but this is how Universal Links are managed at Apple and there is not much we can do here. So, that is why I want to make sure we have the right copy on the option.

[ewachowiak]

Based on competitive research and discussion with the team, we are recommending we both change the copy and reverse the meaning of the toggle.

New copy: "Block opening external apps"
New toggle meaning: Off by default (means links will open in external apps as determined by Apple), On means we will block external apps from opening and open the links in the browser instead.

[dicarobinho]

@ewachowiak Here is the change. For the other texts, my suggestion is to have another task.

[ewachowiak]

Please excuse me for having Friday brain last week. I forgot that the setting itself needs to be in title case. Can we please change the copy to "Block Opening External Apps"? Sorry for this mistake.

Additionally, I am hoping we can still address the 2 subcopy strings that should be in sentence case:

• "When Opening Firefox" --> "When opening Firefox"
• When Long-pressing Links --> "When long-pressing links"

This will help us better standardize our settings and reduce UX debt.

[dicarobinho]

@ewachowiak This is how it looks.

Note: I also changed this:

"When Opening Firefox" --> "When opening Firefox"
When Long-pressing Links --> "When long-pressing links"

but the new texts will be available only when the localization team will do also the changes.

[nbhasin2]

@dicarobinho make sure to update the keys before merging

[mobiletest-ci-bot]

	Warnings
⚠️	Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️	Variable 'cross' in Medium is out of alphabetical order.

	Messages
📖	Project coverage: 32.46%
📖	Edited 4 files
📖	Created 0 files

Client.app: Coverage: 31.06

File	Coverage
AppSettingsTableViewController.swift	23.82%	⚠️
BrowserViewController+WebViewDelegates.swift	3.27%	⚠️

Generated by 🚫 Danger Swift against 22a9f66

[willfs84]

Thank you for doing this. And when Firefox is in private mode, you set it to block whether that toggle is on or off? That would fix #20060 #6717 #8417 (it's been filed 3 times)